Nir Soffer has posted comments on this change.
Change subject: tests: FakeLVM test command failure ......................................................................
Patch Set 8: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/47864/8/tests/storagefakelib.py File tests/storagefakelib.py:
Line 115: opened=False, Line 116: active=bool(activate)) Line 117: Line 118: try: Line 119: lv_count = int(self.vgmd[vgName]['lv_count']) + 1 Seems that you missed my comment about missing 'lv_count', would be hidden as missing vg.
Should separate getting the vg from modifying it. Line 120: except KeyError: Line 121: raise se.CannotCreateLogicalVolume(vgName, lvName) Line 122: Line 123: if (vgName, lvName) in self.lvmd: