Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: Fix help string and usage for --disable-libvirt-sanlock
......................................................................
Patch Set 4:
(1 comment)
....................................................
File configure.ac
Line 47
Line 48
Line 49
Line 50
Line 51
No. According to the official document, the example packages I mentioned in the last patch
set discussion and output from ./configure, the following help string styles are
encouraged.
--enable-xxx[=value] plain English [default=yes]
--enable-xxx[=value] plain English [default=no]
--disable-xxx plain English
So we only remove "[default=value]" from help string of
"--disable-xxx", because "--disable-xxx" does not accept value. Even
it accepts value actually, it's not in official documentation and not in the example
packages I examined. So it's not encouraged.
--
To view, visit
http://gerrit.ovirt.org/19005
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I935693a8b8e7c371c653853b9524c9a774bca6fd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes