Zhou Zheng Sheng has posted comments on this change.
Change subject: clientIF: avoid network backups during _syncLibvirtNetworks ......................................................................
Patch Set 2:
I am not sure with if we should backup or not. Why we need the backup before? Why we do not backup those config now? Why chown to vdsm:root not vdsm:kvm?
The backup behavior when removing libvirt network is introduced in commit 86a10b468be, the related RHBZ is #832765. After reading the code, I still confused with the questions above.
-- To view, visit http://gerrit.ovirt.org/7063 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8b8f992efa10b6846012a1a8295ee7833d485762 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server