Alon Bar-Lev has uploaded a new change for review.
Change subject: cleanup: do not use external program ipcalc for ip validation ......................................................................
cleanup: do not use external program ipcalc for ip validation
IPv4 addresses are simple to parse and validate. No need to execute external process for the task.
Especially if process is not supported by all platforms, and it has no added value.
$ ipcalc -c -4 0.0.0.0 && echo ok ok $ ipcalc -c -4 255.255.255.255 && echo ok ok $ ipcalc -c -m -4 1.1.1.1 && echo ok ok
Change-Id: Ia7d5a6515591147cfc86c9279f69da44f94a9872 Signed-off-by: Alon Bar-Lev alonbl@redhat.com --- M vdsm/configNetwork.py 1 file changed, 16 insertions(+), 15 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/6929/1 -- To view, visit http://gerrit.ovirt.org/6929 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ia7d5a6515591147cfc86c9279f69da44f94a9872 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com