Francesco Romani has posted comments on this change.
Change subject: supervdsm: move udevadm methods to udevadm module ......................................................................
Patch Set 3: Code-Review-1
(2 comments)
seems bad rebase. -1 for visibility.
https://gerrit.ovirt.org/#/c/44808/3/lib/vdsm/udevadm.py File lib/vdsm/udevadm.py:
Line 60: except Error as e: Line 61: logging.error("%s", e) Line 62: Line 63: Line 64: def udevTrigger(self, attr_matches=(), property_matches=()): seems bad rebase, IIUC should be
def trigger(attr_matches=(), property_matches=()): Line 65: ''' Line 66: Request device events from the kernel. Line 67: Line 68: Arguments:
Line 84: Line 85: and causes only events from devices that match Line 86: given property to be triggered. Line 87: ''' Line 88: self.__udevReloadRules() this should be renamed or dropped, propably Line 89: cmd = ['trigger', '--verbose', '--action', 'change'] Line 90: Line 91: for name, value in property_matches: Line 92: cmd.append('--property-match={}={}'.format(name, value))