Dan Kenigsberg has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(3 inline comments)
minor comments
.................................................... File vdsm/vdsmd.init.in Line 499: python @VDSMDIR@/vdsm-restore-net-config do we really need this change? why not make the new script executable just like the former one?
.................................................... File vdsm/vdsm-restore-net-config Line 39: # Remove restored backups I love comments. But I think the function names are clear enough, and here the comments only clutter the code.
Line 48: sys.exit(e.errCode) does anyone care about the specific error code here? are we sure it's even in the 0-127 range? I'd drop the whole try:except clause.
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com