Nir Soffer has posted comments on this change.
Change subject: vm: Add qcow2_compat on create ......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/64377/6/vdsm/virt/vm.py File vdsm/virt/vm.py:
Line 2701: try: Line 2702: qemuimg.create(transientPath, format=qemuimg.FORMAT.QCOW2, Line 2703: backing=diskParams['path'], Line 2704: backingFormat=driveFormat, Line 2705: qcow2_compat=self._dom.qcow2_compat()) self._dom is not a storage domain, this is a libvirt.virDomain object.
Hopefully diskParams contains a domain id, so we can produce a domain manifest object. Line 2706: os.fchmod(transientHandle, 0o660) Line 2707: except Exception: Line 2708: os.unlink(transientPath) # Closing after deletion is correct Line 2709: self.log.exception("Failed to create the transient disk for "