Saggi Mizrahi has posted comments on this change.
Change subject: rest-api: Model StorageDomains ......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/rest/Controller.py Line 417: return StorageDomains(self.ctx) Looks like you'll need a dict here self._linkHandlers = {link: callback, ...} return self._linkHandlers.get(link, errorHandler)
I'd even put the dict as a class field
-- To view, visit http://gerrit.ovirt.org/3751 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I85060179416dc7c4a1a33ef6f8262ce31e908c26 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com