Zhou Zheng Sheng has posted comments on this change.
Change subject: make vdsm/storage/hsm.py PEP8 clean
......................................................................
Patch Set 6: Verified
Thanks guys for reviewing and reminding me to rebase.
Build success, verify using pydiff, the detailed report:
pydiff vdsm/storage/hsm.py ../diffs/hsm.py
2 difference(s)
first file: vdsm/storage/hsm.py
second file: ../diffs/hsm.py
((1707, '=='), (1837, 'is'))
((1708,
"Compare(CallFunc(Name('type'), [Name('force')], None, None),
[('==', CallFunc(Name('type'), [Const('')], None,
None))])"),
(1837,
"CallFunc(Name('isinstance'), [Name('force'),
Name('str')], None, None)"))
It finds two logical changes. You may have a look at line 1707 to 1708 in old version v.s.
line 1837 in new version. I think the changes are acceptable.
--
To view, visit
http://gerrit.ovirt.org/4530
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9b2f8b9e83db6f52678b4e0865668a79bcf53f5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server