Nir Soffer has posted comments on this change.
Change subject: vm: Add qcow2_compat on create ......................................................................
Patch Set 18:
(2 comments)
https://gerrit.ovirt.org/#/c/64377/18/vdsm/virt/vm.py File vdsm/virt/vm.py:
Line 2698 Line 2699 Line 2700 Line 2701 Line 2702 Please fix the format here to use one parameter per line, and then add the compat after format, not after backingFormat.
Line 2698: transientHandle, transientPath = tempfile.mkstemp( Line 2699: dir=config.get('vars', 'transient_disks_repository'), Line 2700: prefix="%s-%s." % (diskParams['domainID'], diskParams['volumeID'])) Line 2701: Line 2702: sdDom = sdCache.produce(sdUUID=diskParams['domainID']) We should produce the safer manifest object for this. Line 2703: try: Line 2704: qemuimg.create(transientPath, format=qemuimg.FORMAT.QCOW2, Line 2705: backing=diskParams['path'], Line 2706: backingFormat=driveFormat,