Mark Wu has posted comments on this change.
Change subject: Fix a race existing in the singleton interface of clientIF ......................................................................
Patch Set 1: Verified
I couldn't find this problem in my previous tests. Sorry for that. To trigger the race, I add a sleep after self._prepareMOM(). It's verified that this patch can resolve the problem.
Here's the traceback message: Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/mom/__init__.py", line 185, in get_hypervisor_interface return module.instance(self.config) File "/usr/lib/python2.7/site-packages/mom/HypervisorInterfaces/vdsmInterface.py", line 160, in instance return vdsmInterface() File "/usr/lib/python2.7/site-packages/mom/HypervisorInterfaces/vdsmInterface.py", line 36, in __init__ self.vdsm_api = API.Global() File "/usr/share/vdsm/API.py", line 974, in __init__ APIBase.__init__(self) File "/usr/share/vdsm/API.py", line 55, in __init__ self._cif = clientIF.getInstance() File "/usr/share/vdsm/clientIF.py", line 123, in getInstance the single clientIF instance") Exception: Logging facility is required to create the single clientIF instance
-- To view, visit http://gerrit.ovirt.org/7283 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6d907f5613963438c99749da674bb6588a23fe38 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server