Dan Kenigsberg has posted comments on this change.
Change subject: test: Add tests for _validateInterNetworkCompatibility() ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
Thanks for extending the unit tests! This is very important in my opinion.
.................................................... File tests/configNetworkTests.py Line 208: 'mtu': 1500 Line 209: }, Line 210: 'eth7.1': { Line 211: 'iface': 'eth7', Line 212: 'addr': None, I don't think we ever have Nones here - it tends to confuse xmlrpc. Line 213: 'netmask': None, Line 214: 'mtu': 1500 Line 215: } Line 216: },
Line 283: configNetwork.ne.ERR_USED_NIC) Line 284: Line 285: # Test for adding a new VLANed bridged network Line 286: # when a non-VLANed bridged network exists Line 287: self._addNetworkWithExc((netinfoIns, 'test', '2', 'bond00', nics, is this intentionally a different bond device? Line 288: ipaddr, netmask, gw, bondingOptions), Line 289: configNetwork.ne.ERR_BAD_PARAMS) Line 290: Line 291: # Test for adding a new VLANed bridgeless network
Line 295: False), Line 296: configNetwork.ne.ERR_BAD_PARAMS) Line 297: Line 298: # Test for adding a new VLANed bridged network Line 299: # when the interface is in used for any type of networks i think English would say "interface is in use by" Line 300: self._addNetworkWithExc((netinfoIns, 'test', vlan, bonding, ['eth7'], Line 301: ipaddr, netmask, gw, bondingOptions), Line 302: configNetwork.ne.ERR_BAD_PARAMS) Line 303:
-- To view, visit http://gerrit.ovirt.org/7241 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I732c8c9f1983261391835e1e3687cf120e9def34 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server