Francesco Romani has posted comments on this change.
Change subject: virt: Migration plugins to enable skipping of special OVS processing for
nics
......................................................................
Patch Set 2: Code-Review-1
After discussions and looking at the code, I'm still uneasy. IMO this patch is a
pretty good sign we are stretching the hooks too thin.
This fix could be good enough in the short term, but we need something more. Does libvirt
lack any capability we need, or that could make our life easy? Should we move the ovs
support more in the Vdsm core and drop the hook? let's talk about this, let's file
libvirt RFEs if needed.
-1 for visibility, will change score once we have plans for long(er) term.
--
To view, visit
https://gerrit.ovirt.org/64186
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0fb056c4b4732505d567385546e78048c37d140
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No