Ido Barkan has posted comments on this change.
Change subject: config: Resolve crash when IPv6 disabled in kernel ......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/47978/1/vdsm/network/configurators/ifcfg.py File vdsm/network/configurators/ifcfg.py:
Line 102: self._addSourceRoute(bridge) Line 103: _ifup(bridge) Line 104: Line 105: # Check if ipv6 is disabled by kernel arguments Line 106: has_ipv6 = True
hmm, I think that we'd better expose this as a memoized function in caps.py
agreed. Line 107: try: Line 108: socket.socket(socket.AF_INET6, socket.SOCK_DGRAM) Line 109: except socket.error: Line 110: has_ipv6 = False