Francesco Romani has posted comments on this change.
Change subject: lib: api.py: preserve signature in decorator ......................................................................
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/63759/7/vdsm.spec.in File vdsm.spec.in:
Line 109: %endif # support python3 Line 110: Line 111: %if 0%{?rhel} Line 112: BuildRequires: python-decorator Line 113: %else # fedora
Please have explicit branch for each platform, no more "else # fedora", thi
Done Line 114: BuildRequires: python2-decorator Line 115: %endif # rhel Line 116: Line 117: # Autotools BuildRequires
Line 144: Requires: iproute >= 3.10.0 Line 145: Requires: PyYAML Line 146: %if 0%{?rhel} Line 147: Requires: python-decorator Line 148: %else # fedora
Same - best to have one block for platform specific requirements , not bloc
Done Line 149: Requires: python2-decorator Line 150: %endif # rhel Line 151: Requires: python-netaddr Line 152: Requires: python-inotify