Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: generating uuid for libvirt configuration (#842115) ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
minor comments. I believe that this patch is not really dependent on the more complex former patch.
.................................................... Commit Message Line 4: Commit: Yaniv Bronhaim ybronhei@redhat.com Line 5: CommitDate: 2012-08-20 11:44:50 +0300 Line 6: Line 7: vdsm: generating uuid for libvirt configuration (#842115) Line 8: I'd mention that the real issue here is that hosts are sometimes shipped with non-unique uuid burned into their bios. Line 9: during migration we found that if both hosts as the same uuid Line 10: libvirt fails the migration. this fix generate uniqe uuid only Line 11: during vdsm reconfiguration. Line 12: this uuid is saved in libvirtd.conf file and ha sbeen used after
Line 8: Line 9: during migration we found that if both hosts as the same uuid Line 10: libvirt fails the migration. this fix generate uniqe uuid only Line 11: during vdsm reconfiguration. Line 12: this uuid is saved in libvirtd.conf file and ha sbeen used after ha sbeen -> is Line 13: libvirt service are restarted. Line 14: Line 15: Change-Id: I12478f64850dc3b3e421a562762c020819c8be28
Line 9: during migration we found that if both hosts as the same uuid Line 10: libvirt fails the migration. this fix generate uniqe uuid only Line 11: during vdsm reconfiguration. Line 12: this uuid is saved in libvirtd.conf file and ha sbeen used after Line 13: libvirt service are restarted. are -> is Line 14: Line 15: Change-Id: I12478f64850dc3b3e421a562762c020819c8be28
.................................................... File vdsm/vdsmd.init.in Line 346: set_if_default $lconf unix_sock_group "kvm" Line 347: set_if_default $lconf unix_sock_rw_perms "0770" Line 348: set_if_default $lconf auth_unix_rw "sasl" Line 349: set_if_default $qconf dynamic_ownership 0 Line 350: set_if_default $lconf host_uuid "$(uuidgen)" I'd join this line with the other $lconf changes. Line 351: Line 352: if [[ "$ssl" == true ]]; then Line 353: set_if_default $qconf spice_tls 1 Line 354: else
-- To view, visit http://gerrit.ovirt.org/7332 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I12478f64850dc3b3e421a562762c020819c8be28 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server