Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: Fix help string and usage for --disable-libvirt-sanlock
......................................................................
Patch Set 3:
(1 comment)
....................................................
File configure.ac
Line 58: AC_ARG_ENABLE(
Line 59: [libvirt-sanlock],
Line 60: [AS_HELP_STRING(
Line 61: [--disable-libvirt-sanlock],
Line 62: [disable libvirt sanlock plugin, enabled by default]
This help string is not telling the user to use
"--disable-libvirt-sanlock=enabled", but just to telling a fact that "this
feature is enabled by default" in plain English. We still use "yes" and
"no" as the enable variable value in the code.
As I mentioned in the commit message, "--disable-xxx=yes|no" is confusing for
people with a different culture background. This is not a problem of understanding
--disable-xxx=no conventions, it's just counter intuition from my point of view. So
I'd prefer not to use "--disable-xxx=yes|no", but just
"--disable-xxx". In this patch, the help string suggests user to use
"--disable-xxx" and eliminates the ambiguity.
Line 63: )],
Line 64: ,
Line 65: [enable_libvirt_sanlock="yes"]
Line 66: )
--
To view, visit
http://gerrit.ovirt.org/19005
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I935693a8b8e7c371c653853b9524c9a774bca6fd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes