Nir Soffer has posted comments on this change.
Change subject: blockSD: raise an exception if missing physical volume ......................................................................
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/27442/4/vdsm/storage/lvm.py File vdsm/storage/lvm.py:
Line 824: def getPV(pv): Line 825: pv = _lvminfo.getPv(_fqpvname(pv)) Line 826: if not pv: Line 827: raise se.InaccessiblePhysDev(pv) Line 828: else:
I do not like it either, but I tried to be consistent with the same behavio
You got my +1 for killing such code anywhere :-) Line 829: return pv Line 830: Line 831: Line 832: def getAllPVs():