Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 4: (6 inline comments)
.................................................... Commit Message Line 27: tarball name has interface version so several versions may be provided I think we discussed this.
As we have vdsm-bootstrap package that should be installed with several engines we need to support multiple interfaces.
I believe a better solution is to move the bootstrap out of the vdsm project, into the engine or as standalone. So that engine and bootstrap version can be independent of the vdsm version and repository.
.................................................... File vds_bootstrap/Makefile.am Line 31: # old servers to use upgraded package Right.
.................................................... File vds_bootstrap/vds_bootstrap_complete.py Line 73: if o == "-v": right. Or better key=value to allow more flexibility.
I will do this once I rewrite not now.
.................................................... File vds_bootstrap/vds_bootstrap.py Line 62: filename='/tmp/vdsm-bootstrap-phase1.%s.log' % (strftime("%Y%m%d%H%M%S")), Done
Line 741: global bootstrap_interface_version Done
.................................................... File vdsm_reg/deployUtil.py.in Line 60: _WORK_DIR = "/tmp" # hardcoded as server use it as-is Because the engine hardcoded to get output from /tmp.
We went over and over this issue, this is how it runs now, it was wrong to have this statement at bootstrap side as long as server hardcoded to use /tmp.
For future we can discuss how to sync directories between engine and vdsm.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server