Dan Kenigsberg has posted comments on this change.
Change subject: vdsm | netinfo : Return Mac of bond slaves in lower case ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Minor comment about the commit message. Other than that, the patch seems fine.
http://gerrit.ovirt.org/#/c/31888/1//COMMIT_MSG Commit Message:
Line 3: AuthorDate: 2014-08-25 12:43:46 +0300 Line 4: Commit: Genadi Chereshnya gcheresh@redhat.com Line 5: CommitDate: 2014-08-25 12:43:46 +0300 Line 6: Line 7: vdsm | netinfo : Return Mac of bond slaves in lower case There's no need for the "vdsm" prefix. It's the vdsm project, so it adds nothing. Please drop the space before the colon, too. Line 8: Line 9: getVdsCaps returns MAC of all interfaces in lower case and for bond slaves Line 10: it returned it in upper cases - fixing inconsistency Line 11: