Igor Lvovsky has posted comments on this change.
Change subject: BZ#846004 - IP on nic/bond should be preserved when VLAN added ......................................................................
Patch Set 6: (1 inline comment)
.................................................... File vdsm/configNetwork.py Line 435: if not mtu: Line 436: mtu = confParams.get('MTU', None) Line 437: if mtu: Line 438: mtu = int(mtu) Line 439: Yes, I know that probably we can refactor it to different function, but
1. I don't find proper name for this function ;) 2. anyway ifaceUsers question should stay here 3. return dict and parse it here looks ugly as well 4. It's too late and I am too tired Line 440: self._createConfFile(conf, bonding, ipaddr, netmask, gateway, Line 441: bootproto, mtu, onboot, **kwargs) Line 442: Line 443: # create the bonding device to avoid initscripts noise
-- To view, visit http://gerrit.ovirt.org/7259 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5a6481c64c285b8a9bd6f6cc49c1c84507c91603 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server