Adam Litke has posted comments on this change.
Change subject: (Schema) Replace FloatStr with float ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
Regarding the double comment I made against the first series, I can just represent floats as doubles during code generation.
-- To view, visit http://gerrit.ovirt.org/6842 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3c01ac527d34419e698123bfecca4ff86eca5450 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com