Dan Kenigsberg has posted comments on this change.
Change subject: BZ#815825: backup certs during registration ......................................................................
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm_reg/deployUtil.py.in Line 1422: for pemFile in range(len(certs)): that's not pythonic enough
for pemFile in certs:
would give you what you want, cheaper.
Line 1440: certs.append(VDSMCERT) no need to append a list
_nodeBackupCerts([CACERT, VDSMCERT])
is shorter and more readable.
-- To view, visit http://gerrit.ovirt.org/3883 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia8569b5379ec8af7ad2e6dcafb2eef1fe47ab890 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Michael Burns mburns@redhat.com