Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory ......................................................................
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/43759/7/vdsm/rpc/bindingjsonrpc.py File vdsm/rpc/bindingjsonrpc.py:
Line 37: workers_count=_THREADS, Line 38: max_tasks=_TASKS, Line 39: scheduler=scheduler) Line 40: Line 41: self._server = JsonRpcServer(bridge, timeout, self._executor.dispatch)
Do we have a test for this? if not, maybe add it in this patch?
Will add. Line 42: self._reactor = StompReactor(subs) Line 43: self.startReactor() Line 44: Line 45: def add_socket(self, reactor, client_socket):