Oved Ourfali has posted comments on this change.
Change subject: wip vdsm: improve message when trying to attach import domain with wrong permissions (#842146) ......................................................................
Patch Set 4: (1 inline comment)
.................................................... File vdsm/storage/storageServer.py Line 416: def _getLocalPath(self): Line 417: return os.path.join(self.localPathBase, self._path.replace("_", "__").replace("/", "_")) Line 418: Line 419: def checkTarget(self): Line 420: return os.path.exists(self._path) and os.path.isdir(self._path) Currently, the validateDirAccess function checks for os.R_OK and os.X_OK. Weird that it doesn't check for W_OK. Changing it will effect all locations that use it, but it seems right, as we obviously need write permissions there, right? Line 421: Line 422: def checkLink(self): Line 423: lnPath = self._getLocalPath() Line 424: if os.path.lexists(lnPath):
-- To view, visit http://gerrit.ovirt.org/7339 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I76880b1445f259431d7aa691eda676e1210308e4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server