Dan Kenigsberg has posted comments on this change.
Change subject: configNetwork: Don't swallow exception during removeLibvirtNetwork ......................................................................
Patch Set 1: Looks good to me, approved
swallowing errors is evil. doing this without a clear documented reason is even worse.
-- To view, visit http://gerrit.ovirt.org/6914 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4953348d79bc2ee2bc9dfddc93588e97d3c7a208 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com