Igor Lvovsky has posted comments on this change.
Change subject: Implement __hash__ for mount objects ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
.................................................... File vdsm/storage/mount.py Line 99: hsh ^= hash(self.fs_file) why do you need hash(type(self)) ?
-- To view, visit http://gerrit.ovirt.org/1691 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I771eff8c87a1f4f96dd7e743af69f6c941ac7180 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com