Ayal Baron has posted comments on this change.
Change subject: Improve the lvm.USER_DEV_LIST parsing ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
.................................................... File vdsm/storage/lvm.py Line 117: USER_DEV_LIST = filter(None, config.get("irs", "lvm_dev_whitelist").split(",")) Do we have unit tests with: 1. no whitelist defined 2. empty whitelist defined 3. whitelist with single device 4. whitelist with multiple devices ???
-- To view, visit http://gerrit.ovirt.org/1890 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8020b990f1b74b081a46de5e215dc27745466186 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com