Edward Haas has posted comments on this change.
Change subject: net: Link setup module - includes bond setup logic.
......................................................................
Patch Set 7: Verified+1
(2 comments)
https://gerrit.ovirt.org/#/c/62831/1/lib/vdsm/network/link/setup.py
File lib/vdsm/network/link/setup.py:
Line 25:
Line 26: from .bond import Bond
Line 27:
Line 28:
Line 29: class SetupBonds(object):
will there be a Transaction?
I haven't seen a need for now,
if you do, please let me know.
Line 30: def __init__(self, bonds2add, bonds2edit, bonds2remove):
Line 31: self._bonds2add = bonds2add
Line 32: self._bonds2edit = bonds2edit
Line 33: self._bonds2remove = bonds2remove
PS1, Line 44: set
frozenset?
Interesting what is the result of operations between
a set and a frozenset..
--
To view, visit
https://gerrit.ovirt.org/62831
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes