Ryan Harper has posted comments on this change.
Change subject: Fix vdsm-faqemu VM launch failure on hosts with newer libvirt ......................................................................
Patch Set 1: Verified
Updated this patch to replace exec of touch. Also added a check to only attempt to touch /dev/kvm if it's not present. This prevents the need to actually open the file for writing, which fails permission checks if the file already exists (for example from a previous exec of the hook).
I've tested this with:
1) running 3.1 release engine against to F17 VMs with the hook installed. 2) Creating a VM on the host (fails without this) 3) stopping a VM on the host 4) starting the VM a second time (this failed without the check to see if /dev/kvm already exists).
-- To view, visit http://gerrit.ovirt.org/7359 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iffe19758171e3808e42ed50d309dc4be1f9492cc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com