Dan Kenigsberg has submitted this change and it was merged.
Change subject: improve message when trying to attach import domain with wrong permissions ......................................................................
improve message when trying to attach import domain with wrong permissions
When a storage domain is attached, and there is something wrong with the directory permissions, then the operation fails with "Cannot obtain lock" error. This patch improves the error in this case, by performing validations when doing the server connection. If the permission validation fails, we disconnect.
The user will get an event specifying the permissions error. And, he will get a UI error saying: "There is no storage domain under the specified path. Please check path."
This fix also applies to posix and local storage.
Bug-Id: BZ#842146 Change-Id: I76880b1445f259431d7aa691eda676e1210308e4 Signed-off-by: Oved Ourfali oourfali@redhat.com --- M vdsm/storage/fileSD.py M vdsm/storage/localFsSD.py M vdsm/storage/nfsSD.py M vdsm/storage/storageServer.py M vdsm/storage/storage_exception.py 5 files changed, 27 insertions(+), 24 deletions(-)
Approvals: Eduardo: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Oved Ourfali: Verified
-- To view, visit http://gerrit.ovirt.org/7339 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I76880b1445f259431d7aa691eda676e1210308e4 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server