Zhou Zheng Sheng has posted comments on this change.
Change subject: Modify pthread.py comply to pep8 ......................................................................
Patch Set 5: (1 inline comment)
A small problem in Makefile.am. Please refer to inline comment.
.................................................... File Makefile.am Line 48: vdsm/pthread.py \ Need tab here. If you set expandtab in vim, you can insert a real tab by pressing ctrl+v then the tab key. Or you can delete tab related settings in .vimrc and add this lines:
autocmd FileType python setlocal tabstop=4 shiftwidth=4 expandtab softtabstop=4 autocmd BufEnter *.py setlocal tabstop=4 shiftwidth=4 expandtab softtabstop=4
Now vim only expand tab for you when editing Python source files.
-- To view, visit http://gerrit.ovirt.org/4531 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I466da79448d6004fc17a01586c81d4758016c3be Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com