Antoni Segura Puimedon has posted comments on this change.
Change subject: tc: list some information about filters ......................................................................
Patch Set 2: (1 inline comment)
Only small typo. The rest looks good to me, even though it took me a moment to realize the intent yielding the last entry by adding a bogus extra line containing HEADER+X.
.................................................... File vdsm/tc.py Line 93: Line 94: Line 95: def filters(dev, parent, out=None): Line 96: """ Line 97: Return a (very) limitted information about tc filters on dev s/limitted/limited/ Line 98: Line 99: Function returns a generator of Filter objects. Line 100: """ Line 101:
-- To view, visit http://gerrit.ovirt.org/7298 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I22953e6d09f846cae18d15a54cd6e5c9e4519e20 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server