Nir Soffer has posted comments on this change.
Change subject: vdsm: Rely on system for logrotation
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/63682/3/vdsm/vdsm-remove-logs
File vdsm/vdsm-remove-logs:
Line 15: /usr/bin/logger -t vdsm "ALERT clean of old import log files exited
abnormally with [$EXITVALUE]"
Line 16: fi
Line 17: fi
Line 18:
Line 19: exit $EXITVALUE
For another day, it would be nice to fix this bug. If the first operation failed and the
second succeeded, we lie and return 0.
--
To view, visit
https://gerrit.ovirt.org/63682
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica888244bd7c65121f55983e5716a6eae5662879
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes