Francesco Romani has posted comments on this change.
Change subject: spice: allow to disable the agent file transfer ......................................................................
Patch Set 25:
(2 comments)
http://gerrit.ovirt.org/#/c/26917/25/vdsm.spec.in File vdsm.spec.in:
Line 138: Requires: libvirt-daemon-driver-nwfilter Line 139: Requires: libvirt-daemon-driver-qemu Line 140: %else Line 141: %if 0%{?rhel} Line 142: Requires: libvirt >= 0.10.2-29.el6_5.4
Does this RHEL6 version of libvirt support the filetransfer?
Actually not, we require libvirt-0.10.2-35.el6.x86_64. Will fix. Line 143: %else Line 144: Requires: libvirt >= 1.2.2-1 Line 145: %endif Line 146: %endif
http://gerrit.ovirt.org/#/c/26917/25/vdsm_api/vdsmapi-schema.json File vdsm_api/vdsmapi-schema.json:
Line 3251: 'data': {'acpiEnable': 'bool', 'clientIp': 'str', 'copyPasteEnable': 'bool', Line 3252: 'cpuShares': 'str', '*cpuType': 'str', '*custom': 'StringMap', Line 3253: '*devices': ['VmDevice'], 'display': 'VmDisplayType', 'displayIp': 'str', Line 3254: 'displayPort': 'int', 'displaySecurePort': 'int', Line 3255: '*emulatedMachine': 'str', 'fileTransferEnable': 'bool', '*keyboardLayout': 'str',
If this is optional it needs to be prefixed with *
Right, stupid typo. Will fix. Line 3256: 'kvmEnable': 'bool', '*maxVCpus': 'uint', 'memSize': 'uint', Line 3257: 'memGuaranteedSize': 'uint', 'nicModel': 'str', 'nice': 'int', Line 3258: '*pauseCode': 'str', 'pid': 'uint', 'smp': 'uint', '*smpCoresPerSocket': 'uint', Line 3259: '*smpThreadsPerCore': 'uint', 'status': 'VmStatus',