Hans De Goede has posted comments on this change.
Change subject: vdsClient.py: Allow specifying nested dicts for devices when creating a vm ......................................................................
Patch Set 1:
Igor,
You're right that vdsClient already works with devices=... including *limited* support for dicts in the form of devices=attr1:value,attr2:value
But it is missing 2 important things making it impossible to properly test creating vms with "complex" devices setups: 1) It does not support nested dicts 2) It does not set the proper type on values, leaving them all as strings (where as for example readOnly needs to be a boolean and index needs to be a string.
Regards,
Hans
-- To view, visit http://gerrit.ovirt.org/4094 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibe4eb528684c1d2053cb9574d8f63bbbf0a03c23 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hans De Goede hdegoede@redhat.com Gerrit-Reviewer: Hans De Goede hdegoede@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com