From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: enable tlsv1.2 support ......................................................................
Patch Set 30:
(1 comment)
https://gerrit.ovirt.org/#/c/72284/30/lib/vdsm/sslutils.py File lib/vdsm/sslutils.py:
Line 272: protocols = [] Line 273: Line 274: for no_protocol in config.get('vars', 'ssl_protocol').split(','): Line 275: if no_protocol != '': Line 276: protocols.append(getattr(ssl, no_protocol.strip()))
Correct, now we have protocol and excludes.
Internally, I don't think that we really need protocol - we should always use PROTOCOL_TLS, and always pepper options on top of it.
this function should translate whatever a user requested hitorically into the OP_NO_* integer which we should be using to give them what they wanted. Line 277: