Zhou Zheng Sheng has posted comments on this change.
Change subject: Make vdsm/storage/fileSD.py pep8 clean ......................................................................
Patch Set 2: Verified; Looks good to me, but someone else must approve
Run through autobuild.sh. pydiff says the only difference is changing "volumes.has_key(volUUID)" to "volUUID in volumes", so it's acceptable. The detailed report is as follow.
$ pydiff fileSD*.py 1 difference(s) first file: fileSDo.py second file: fileSD.py
((311, "CallFunc(Getattr(Name('volumes'), 'has_key'), [Name('volUUID')], None, None)"), (325, "Compare(Name('volUUID'), [('in', Name('volumes'))])"))
Review the new style, looks good.
-- To view, visit http://gerrit.ovirt.org/7520 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I79e4e8bf82213c31269a6fe1fefddf619a34b82f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server