Francesco Romani has posted comments on this change.
Change subject: spice: allow to disable the agent file transfer ......................................................................
Patch Set 38:
(1 comment)
I'll try to summarize the point.
- I agree dropping the clusterLevel for this is an extreme measure :) - RHEL libvirt will be OK (there are fixed bugzillas to ensure this) in d/s, so no issue here. - libvirt u/s will be fine starting with 1.2.2 included. This will rule out F19, even with virt-preview enabled; F20 will be OK with virt-preview enabled only, not with stock packages. - for the above reason, just requiring libvirt >= 1.2.2 is probably too extreme as well - if coupled with old libvirt, VDSM will still work just fine since all the interaction is done using XML fields; - there is no way to detect the support for this feature except for the version check :( - if we just drop any requirement of libvirt we have to move the version check on the engine somehow and we grey out/disable the support engine-side. I'm not sure this way is better than the others.
http://gerrit.ovirt.org/#/c/26917/38/vdsm/caps.py File vdsm/caps.py:
Line 589: logging.error('libvirt does not support the SPICE control' Line 590: ' features, (file transfer disable), support' Line 591: ' for clusterLevel >= 3.5 is disabled.' Line 592: ' Consider upgrading to libvirt >= 1.2.2') Line 593: maxClusterVer = '3.5'
I'd use 3.4 and 3.3 below and change the comparison accordingly @577
Will change. Line 594: if not hasattr(libvirt, 'VIR_MIGRATE_ABORT_ON_ERROR'): Line 595: logging.error('VIR_MIGRATE_ABORT_ON_ERROR not found in libvirt,' Line 596: ' support for clusterLevel >= 3.4 is disabled.' Line 597: ' For Fedora 19 users, please consider upgrading'