Ayal Baron has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 13: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/storage/volume.py Line 464: def _legacySetRW(self, rwMode): shouldn't this method be annotated as deprecated instead of having 'legacy' in the name?
also, why not have a decorator for the version logic? (only run if x < whatever)
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com