Dan Kenigsberg has posted comments on this change.
Change subject: BZ#815825: backup certs during registration ......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm_reg/deployUtil.py.in Line 1418: def _nodeBackupCerts(caCert, vdsmCert): I think the function would be prettier if it simply accepted a list of certs to backup.
Line 1427: for pemFile in certs: I find this cumbersome, relative to the simple
for pemFile in (caCert, vdsmCert):
-- To view, visit http://gerrit.ovirt.org/3883 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia8569b5379ec8af7ad2e6dcafb2eef1fe47ab890 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Michael Burns mburns@redhat.com