Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#833084 Set StoragePool.id to SPM_ID_FREE by default ......................................................................
BZ#833084 Set StoragePool.id to SPM_ID_FREE by default
Setting the storage pool id to SPM_ID_FREE (-1) would prevent mistakes that could lead None to appear in the metadata. In this patch: * replace the storage pool id value None with SPM_ID_FREE * replace the storage pool lver value None with LVER_INVALID * validate the hostId in reconstructMaster
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: Ifd0276f106f7a586025b8d3329ede1aac5a9905b --- M vdsm/storage/hsm.py M vdsm/storage/sp.py 2 files changed, 18 insertions(+), 10 deletions(-)
Approvals: Ayal Baron: Looks good to me, approved Daniel Paikov: Verified Dan Kenigsberg:
-- To view, visit http://gerrit.ovirt.org/7268 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ifd0276f106f7a586025b8d3329ede1aac5a9905b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Daniel Paikov paikov@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server