Alon Bar-Lev has posted comments on this change.
Change subject: cleanup: do not use external program ipcalc for ip validation ......................................................................
Patch Set 1: (2 inline comments)
.................................................... File vdsm/configNetwork.py Line 469: ret = False Done
Line 477: except: I thought of any other case which may fail this... are you sure you want a specific error?
-- To view, visit http://gerrit.ovirt.org/6929 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia7d5a6515591147cfc86c9279f69da44f94a9872 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com