Dan Kenigsberg has submitted this change and it was merged.
Change subject: storage connection monitor: don't recover an unmanaged connection ......................................................................
storage connection monitor: don't recover an unmanaged connection
A connection can be deleted (unmanage) when the storage connection monitor thread is in in Event.wait(). When the monitor thread continues to execute, it thinks the connection is lost and try to recover it, but the fact is it is unmanaged. This bug prevent iscsi connections from releasing cleanly.
This patch checks if the connection is still managed by the monitor before recovering it.
Change-Id: I9bc2b1f18f3421039b1d85d1e7a47c746ebfc31a Signed-off-by: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com --- M vdsm/storage/storageServer.py 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: Ayal Baron: Looks good to me, approved Dan Kenigsberg: Deepak C Shetty: Looks good to me, but someone else must approve Zhou Zheng Sheng: Verified
-- To view, visit http://gerrit.ovirt.org/10297 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I9bc2b1f18f3421039b1d85d1e7a47c746ebfc31a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server