Dan Kenigsberg has submitted this change and it was merged.
Change subject: extract a method for appending a child node with a text node to self.dom
in libvirtvm.py
......................................................................
extract a method for appending a child node with a text node to self.dom
in libvirtvm.py
In vdsm/libvirtvm.py, there are some duplicated code. It creates an
xml element node, then creates a text node and appends it to the element,
at last appends the element to self.dom. This can be done in a function.
Change-Id: Ie05d8f0f9869080b34d5cafb5c672d4034f09934
Signed-off-by: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
---
M vdsm/libvirtvm.py
1 file changed, 12 insertions(+), 12 deletions(-)
Approvals:
oVirt Jenkins CI Server: Verified
Dan Kenigsberg: Looks good to me, approved
Zhou Zheng Sheng: Verified
--
To view, visit
http://gerrit.ovirt.org/6846
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie05d8f0f9869080b34d5cafb5c672d4034f09934
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server