Nir Soffer has posted comments on this change.
Change subject: [WIP] core: Expose API for qemuimg commit ......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py File tests/qemuimg_test.py:
Line 347: Line 348: Line 349: @MonkeyPatch(qemuimg, 'config', CONFIG) Line 350: @permutations(((qemuimg.FORMAT.RAW,), (qemuimg.FORMAT.QCOW2,))) Line 351: def test_commit(self, baseFormat): Use only lower_case names - in the module api we want to be consistent with the old apis, but in the tests we are free to use new vdsm style. Line 352: with namedTemporaryDir() as tmpdir: Line 353: base = os.path.join(tmpdir, 'base.img') Line 354: top = os.path.join(tmpdir, 'top.img') Line 355: size = 1048576