Michal Skrivanek has posted comments on this change.
Change subject: vm: make acpiShutdown more robust ......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34879/1/vdsm/virt/vm.py File vdsm/virt/vm.py:
Line 4404: self._shutdownReason = vmexitreason.ADMIN_SHUTDOWN Line 4405: try: Line 4406: self._dom.shutdownFlags(libvirt.VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN) Line 4407: except AttributeError: Line 4408: if not self._released: well, there is still a room for a race. How about not raising anything, just a warn that it has not been sent? Line 4409: raise Line 4410: # else the VM was already shut off asynchronously, Line 4411: # so ignore error and quickly exit Line 4412: