Saggi Mizrahi has posted comments on this change.
Change subject: Prepare each vm volumes instead of prepare blockSD ......................................................................
Patch Set 7: I would prefer that you didn't submit this
(7 inline comments)
.................................................... File vdsm/storage/image.py Line 348: if tmplVolume: Line 349: chain.insert(0, tmplVolume) Line 350: Line 351: # perform prepare on top volume (this will recusivly prepare all chain) Line 352: if chain[-1]: I think you meant, if len(chain) >= 1: Line 353: chain[-1].prepare() Line 354: self.log.debug("MyPrepare: producing prepare on top chain") Line 355: else: Line 356: self.log.debug("MyPrepare: no chain exist - weird")
Line 350: Line 351: # perform prepare on top volume (this will recusivly prepare all chain) Line 352: if chain[-1]: Line 353: chain[-1].prepare() Line 354: self.log.debug("MyPrepare: producing prepare on top chain") What is MyPrepare? Line 355: else: Line 356: self.log.debug("MyPrepare: no chain exist - weird") Line 357: Line 358: sdCache.produce(sdUUID).activateVolumes(
Line 352: if chain[-1]: Line 353: chain[-1].prepare() Line 354: self.log.debug("MyPrepare: producing prepare on top chain") Line 355: else: Line 356: self.log.debug("MyPrepare: no chain exist - weird") Warning Line 357: Line 358: sdCache.produce(sdUUID).activateVolumes( Line 359: volUUIDs=[vol.volUUID for vol in chain]) Line 360: return chain
Line 361: Line 362: def teardown(self, sdUUID, imgUUID, volUUID=None): Line 363: chain = self.getChain(sdUUID, imgUUID, volUUID) Line 364: Line 365: if chain[-1]: Again Line 366: chain[-1].teardown(sdUUID, chain[-1].volUUID) Line 367: self.log.debug("MyTearDown: doing that") Line 368: else: Line 369: self.log.debug("MyTearDown: something wrong..")
Line 363: chain = self.getChain(sdUUID, imgUUID, volUUID) Line 364: Line 365: if chain[-1]: Line 366: chain[-1].teardown(sdUUID, chain[-1].volUUID) Line 367: self.log.debug("MyTearDown: doing that") Is this for testing? Line 368: else: Line 369: self.log.debug("MyTearDown: something wrong..") Line 370: Line 371: # Deactivating the volumes
Line 365: if chain[-1]: Line 366: chain[-1].teardown(sdUUID, chain[-1].volUUID) Line 367: self.log.debug("MyTearDown: doing that") Line 368: else: Line 369: self.log.debug("MyTearDown: something wrong..") warning Line 370: Line 371: # Deactivating the volumes Line 372: sdCache.produce(sdUUID).deactivateVolumes( Line 373: volUUIDs=[vol.volUUID for vol in chain])
.................................................... File vdsm/storage/resourceFactories.py Line 70: lvvg = resourceName.split('/') Line 71: return VolumeWatcher(lvvg[0], lvvg[1]) Line 72: except: Line 73: log.error("error creating resource name: %s", resourceName) Line 74: unrelated Line 75: class LvmActivation(object): Line 76: """ Line 77: Represents activation state of the LV. Line 78: When the resource is created (i.e. the LV is being activated)
-- To view, visit http://gerrit.ovirt.org/8050 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I25b9c260a7de5f883420a5322f90195b3379e80e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com