Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Extract helpers for major XML elements ......................................................................
virt: Extract helpers for major XML elements
Now drive xml is built using small helper methods creating each of the elements. This is more maintainable and will allow creating drive replica xml without code duplication.
Change-Id: I6ef6a38d3abc14413f1001a8673f38fce8d828b7 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: https://gerrit.ovirt.org/40066 Reviewed-by: Adam Litke alitke@redhat.com Reviewed-by: Federico Simoncelli fsimonce@redhat.com --- M vdsm/virt/vmdevices/storage.py 1 file changed, 61 insertions(+), 48 deletions(-)
Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Federico Simoncelli: Looks good to me, but someone else must approve