Ayal Baron has posted comments on this change.
Change subject: udev: Race fix- load and trigger dev rule ......................................................................
Patch Set 10: Looks good to me, approved
(2 inline comments)
Minor comments inside (can and should be in a separate patch probably)
.................................................... File vdsm/supervdsmServer.py Line 312: reload = "--reload-rules" Line 313: cmd = [EXT_UDEVADM, 'control', reload] Line 314: rc, out, err = misc.execCmd(cmd, sudo=False) Line 315: if rc: Line 316: self.log.error("Udevadm reload-rules command failed rc=%s, " technically you should replace 'reload-rules' with %s and reload variable from above Line 317: "out="%s", err="%s"", rc, out, err) Line 318: raise OSError(errno.EINVAL, "Could not reload-rules for device " Line 319: "%s" % guid) Line 320:
Line 314: rc, out, err = misc.execCmd(cmd, sudo=False) Line 315: if rc: Line 316: self.log.error("Udevadm reload-rules command failed rc=%s, " Line 317: "out="%s", err="%s"", rc, out, err) Line 318: raise OSError(errno.EINVAL, "Could not reload-rules for device " same or just 'reload rules' Line 319: "%s" % guid) Line 320: Line 321: @utils.memoized Line 322: def __udevVersion(self):
-- To view, visit http://gerrit.ovirt.org/10758 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If3b2008a3d9df2dcaf54190721c2dd9764338627 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky vvolansk@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Lee Yarwood lyarwood@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Vered Volansky vvolansk@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server